3896 support duplicating and indexing fields on subclass documents in hierarchies #3910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerated storage code (JasperFx#3896) This change addresses JasperFx#3896, where duplicating fields from subclasses (`Duplicate<TSub>`) resulted in unconditional casts in the generated `Upsert`, `Insert`, and `Update` operations. When saving instances of the base type, this caused an `InvalidCastException`. Changes include: * Updated `UpsertArgument.GenerateCodeToSetDbParameterValue` to perform safe type checks before casting to the subclass. * Applied the same safe access pattern in `GenerateBulkWriterCodeAsync` to avoid runtime cast errors. * Extended use of `AccessorString` with guards for subtype casting. * Added XML documentation for both `Duplicate<TSub>` overloads in `DocumentMappingExpression` and `DocumentMapping<T>` to clarify API intent. Impact: * Subclass fields can now be safely marked as duplicated fields without causing runtime cast exceptions. * Generated storage code works correctly for mixed collections of base type and subclass instances. * API documentation now clearly describes the usage and parameters of `Duplicate<TSub>`.
CS0411: The type arguments for method 'IGroupedParameterBuilder.AppendParameter<T>(T?)' cannot be inferred from the usage. Try specifying the type arguments explicitly.
Ensure generated storage operations use the underlying value type (e.g. string, Guid) when accessing .Value on strongly-typed IDs within conditional expressions. This prevents CS1503 compiler errors caused by mismatched types between true/false branches and allows correct parameter binding for nullable and non-nullable strong-typed IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #3896 , where duplicating fields from subclasses (
Duplicate<TSub>) resulted in unconditional casts in the generatedUpsert,Insert, andUpdateoperations.When saving instances of the base type, this caused an
InvalidCastException.Changes include:
UpsertArgument.GenerateCodeToSetDbParameterValueto perform safe type checks before casting to the subclass.GenerateBulkWriterCodeAsyncto avoid runtime cast errors.AccessorStringwith guards for subtype casting.Duplicate<TSub>overloads inDocumentMappingExpressionandDocumentMapping<T>to clarify API intent.Impact:
Duplicate<TSub>.